fix: final polish — handle leak, double-log, exit codes, summaries, checksums#2
Merged
FeelTheFonk merged 2 commits intomainfrom Feb 19, 2026
Merged
fix: final polish — handle leak, double-log, exit codes, summaries, checksums#2FeelTheFonk merged 2 commits intomainfrom
FeelTheFonk merged 2 commits intomainfrom
Conversation
…hecksums - fix(acl): add RegKey.Close() before second OpenSubKey in Grant-RegistryAccess (handle leak) - fix(log): Start-Transcript now writes to killSlop_transcript.txt (separate from structured log) - fix(ci): CI now triggers on push to dev AND main for immediate feedback - fix(prepare): all error Exit → Exit 1; user-cancel → Exit 0; platform (23H2/24H2) → 24H2 - fix(kill): add comment explaining SilentlyContinue; add SYNC-REQUIRED comment on service list - feat(verify): human-readable StartType mapping (Disabled/Manual/Automatic); summary stats (X/11 DISABLED) - fix(verify): PS5.1-compatible StartType mapping (no ?? operator); SYNC-REQUIRED comment - fix(release): add SHA256 checksum generation + attach .sha256 to GitHub Release - fix(settings): add rationale comments for excluded rules - fix(gitignore): artefacts → artifacts; add *.tmp, *~, .env, *.secret - fix(claude): GPO count 12 vals → 10 vals (factual); update staging dir note Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tings.psd1 Non-ASCII characters (U+2014 em dash) triggered PSUseBOMForUnicodeEncodedFile on PowerShell 7 (GitHub Actions CI). Replaced with standard ASCII hyphens. Lint now passes cleanly on both PS5.1 and PS7. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polish final post-v0.0.3 — 14 défauts résiduels éradiqués, zéro fonctionnalité modifiée.
Bugs réels (Tier 1)
RegKey.Close()ajouté entre les deuxOpenSubKeydansGrant-RegistryAccessStart-Transcriptécrit désormais danskillSlop_transcript.txt(séparé du log structurékillSlop_log.txt)devETmain(feedback immédiat sans attendre la PR)Incohérences factuelles (Tier 2)
CLAUDE.md:GPO injection (12 vals)→(10 vals)(décompte réel dans le script)1_prepare_safemode.ps1: platform(23H2 / 24H2)→24H2SYNC-REQUIREDajouté dans2_kill_defender.ps1ET3_verify_status.ps1Qualité & professionnalisme (Tier 3)
Exit→Exit 1/Exit 0dans tous les chemins de1_prepare_safemode.ps13_verify_status.ps1: Start type4→Disabled(mapping human-readable, compatible PS5.1)3_verify_status.ps1: Résumé finalX/11 DISABLED | Y RUNNING (ALERT) | Z MISSING2_kill_defender.ps1: Commentaire expliquant le choix deSilentlyContinuerelease.yml: SHA256 checksum généré + attaché à chaque GitHub ReleasePSScriptAnalyzerSettings.psd1: Commentaires expliquant les règles exclues.gitignore:artefacts→artifacts; ajout*.tmp,*~,.env,*.secretTest plan
3_verify_status.ps1s'exécute sans erreur en PS5.1.zip.sha256git statusclean après merge🤖 Generated with Claude Code